Thanks, applied to master.
On Mon, May 13, 2013 at 12:47:34PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson <et...@nicira.com>
>
> On Fri, May 10, 2013 at 1:34 PM, Ben Pfaff <b...@nicira.com> wrote:
> > netdev_turn_flags_off() does nothing if the flags that one turns off are
> > already off.
> >
> > Reported-by: Ethan Jackson <et...@nicira.com>
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> > lib/netdev-linux.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> > index 30cd0f6..9e2708d 100644
> > --- a/lib/netdev-linux.c
> > +++ b/lib/netdev-linux.c
> > @@ -1019,11 +1019,7 @@ netdev_linux_set_etheraddr(struct netdev *netdev_,
> >
> > /* Tap devices must be brought down before setting the address. */
> > if (!strcmp(netdev_get_type(netdev_), "tap")) {
> > - enum netdev_flags flags;
> > -
> > - if (!netdev_get_flags(netdev_, &flags) && (flags & NETDEV_UP)) {
> > - netdev_turn_flags_off(netdev_, NETDEV_UP, &sf);
> > - }
> > + netdev_turn_flags_off(netdev_, NETDEV_UP, &sf);
> > }
> > error = set_etheraddr(netdev_get_name(netdev_), mac);
> > if (!error || error == ENODEV) {
> > --
> > 1.7.10.4
> >
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
