Acked-by: Ethan Jackson <et...@nicira.com> I made a slight tweak to the patch. Specifically I passed the tcp_flags into action_xlate_ctx_init() instead of mucking with the context directly. I'll merge this and backport it to the relevant branches.
On Sun, May 12, 2013 at 2:53 PM, Ben Pfaff <b...@nicira.com> wrote: > The xlate_actions() call in handle_flow_miss_without_facet() didn't > implement fin_timeout properly because tcp_flags wasn't getting set. > > I have not tested that this fixes the problem, but it seems "obviously > correct". > > Bug #16506. > Reported-by: Ying Chen <yingc...@vmware.com> > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > AUTHORS | 1 + > ofproto/ofproto-dpif.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/AUTHORS b/AUTHORS > index c113f16..498e9f0 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -206,6 +206,7 @@ Vjekoslav Brajkovic bal...@cs.washington.edu > Voravit T. vora...@kth.se > YAMAMOTO Takashi yamam...@valinux.co.jp > Yeming Zhao zhaoyem...@gmail.com > +Ying Chen yingc...@vmware.com > Yongqiang Liu liuyq7...@gmail.com > kk yap yap...@stanford.edu > likunyun kunyu...@hotmail.com > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 1da8ffb..ecb50d5 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -3689,6 +3689,7 @@ handle_flow_miss_without_facet(struct flow_miss *miss, > action_xlate_ctx_init(&ctx, ofproto, &miss->flow, > &miss->initial_vals, rule, 0, packet); > ctx.resubmit_stats = &stats; > + ctx.tcp_flags = stats.tcp_flags; > xlate_actions(&ctx, rule->up.ofpacts, rule->up.ofpacts_len, > &odp_actions); > > -- > 1.7.10.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
