On Mon, May 13, 2013 at 8:44 AM, Kyle Mestery (kmestery)
<kmest...@cisco.com> wrote:
> On May 13, 2013, at 10:33 AM, Jesse Gross <je...@nicira.com> wrote:
>> When sending a packet, a positive length indicates success and a
>> negative length indicates failure. However, the check for success
>> looked for non-zero values which catches both of these cases. This
>> can result in incorrect stats and leak memory on failure.
>>
>> Introduced by commit be7cd27e44258bdb3c4e7dd8fd7389b5db56d55a (datapath:
>> Unify vport error stats handling.).
>>
>> CC: Pravin B Shelar <pshe...@nicira.com>
>> Signed-off-by: Jesse Gross <je...@nicira.com>
>
>
> Nice catch.
>
> Acked-by: Kyle Mestery <kmest...@cisco.com>

Thanks for the quick review, I applied this to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to