On Fri, May 10, 2013 at 01:30:48PM -0700, Ethan Jackson wrote:
> You may disagree, but I think 'renaming it "struct netdev"' sounds
> better than 'renaming it top "struct netdev"'

You mean, grammatically?  OK, I changed the commit message.

> In netdev_bsd_rx_open(), should we call netdev_dev_bsd_changed() for
> both tap devices and non tap devices?

I don't know.  Looking at the change, I believe my intent was to not
change existing behavior in this respect.

> This was pre-existing, but the call to pcap_dispatch() in
> netdev_rx_bsd_recv_pcap() needs a space after the cast.

I've now added the space, thanks.

> Acked-by: Ethan Jackson <et...@nicira.com>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to