On 10 May 2013 11:55, Ben Pfaff <b...@nicira.com> wrote:
> Thanks, I found the problem with valgrind, and here is an incremental
> fix:
>
> diff --git a/lib/netdev.c b/lib/netdev.c
> index 9590f83..415cdb4 100644
> --- a/lib/netdev.c
> +++ b/lib/netdev.c
> @@ -322,8 +322,10 @@ void
>  netdev_close(struct netdev *netdev)
>  {
>      if (netdev) {
> +        struct netdev_dev *dev = netdev_get_dev(netdev);
> +
>          netdev_uninit(netdev, true);
> -        netdev_dev_unref(netdev_get_dev(netdev));
> +        netdev_dev_unref(dev);
>      }
>  }

Ahh, of course.  This fixes the segfaulting tests for me, but the unit
tests now get stuck in "tunnel - input."

(gdb) bt
#0  0x00000008015b4c9c in poll () from /lib/libc.so.7
#1  0x000000000041f693 in time_poll (pollfds=0x801c1a850, n_pollfds=2,
timeout_when=9223372036854775807, elapsed=0x7fffffffca74) at
lib/timeval.c:388
#2  0x0000000000416472 in poll_block () at lib/poll-loop.c:249
#3  0x000000000040ab55 in do_vsctl (args=Variable "args" is not available.
) at utilities/ovs-vsctl.c:4126
#4  0x000000000040b56f in main (argc=47, argv=0x7fffffffcef8) at
utilities/ovs-vsctl.c:220
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to