On Wed, Apr 24, 2013 at 12:12:20PM -0400, Ed Maste wrote: > On 24 April 2013 11:56, Ben Pfaff <b...@nicira.com> wrote: > > On Wed, Apr 24, 2013 at 11:28:45AM -0400, Ed Maste wrote: > >> On 22 April 2013 09:20, YAMAMOTO Takashi <y...@mwd.biglobe.ne.jp> wrote: > >> > + /* > >> > + * note: UINT64_MAX means unsupported > >> > + */ > >> > >> Is this checked anywhere (e.g., to avoid displaying unsupported > >> stats)? Or will it result in the display of bogus values? > > > > It's the return value convention. It's documented in netdev-provider.h: > > > > /* Retrieves current device stats for 'netdev' into 'stats'. > > * > > * A network device that supports some statistics but not others, it > > should > > * set the values of the unsupported statistics to all-1-bits > > * (UINT64_MAX). */ > > int (*get_stats)(const struct netdev *netdev, struct netdev_stats *); > > Thanks Ben, not sure how I missed that. I'm happy enough to have > Yamamoto-san's patch go in and then I can submit a followup to merge > the NetBSD and FreeBSD parts.
OK. I'll wait for Yamamoto-san to repost patches 15 and later with your suggestions and acks applied. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
