I snipped most of your responses, which look fine to me. Thanks. I see one place worth a more detailed response.
On Wed, Apr 17, 2013 at 07:00:17PM -0700, Romain Lenglet wrote: > I wasn't sure about the policy regarding asserts, since there aren't > many in the code. I have mixed feelings about asserts. You can easily have too many of them, some asserts do not have much value (such as those that assert that a pointer is nonnull only a few lines above dereferencing that pointer), and some asserts make code much slower. Also, the consequences of failing an assertion (crashing your program) can be higher than the consequences of plowing ahead (sometimes not crashing). We don't ever compile without assertions, so assertions have to be cheap. These asserts seem OK to me though. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
