On Thu, Mar 21, 2013 at 03:00:29PM -0700, Andy Zhou wrote: > When error is encountered with add-flows command, this patch > adds file name and line number in addition to the parser > error message to the output. > > The file name and line number will not be added to > the output of "ovs-ofctl add-flow", only parser error > message will appear. Same as before. > > Signed-off-by: Andy Zhou <az...@nicira.com>
ofputil_perr_str() to be the same as xasprintf(). Also, it has funny "$"s in its comment. We do not use macros like IF_PERR_*() elsewhere for error handling. They make code harder to understand, so I don't think that it is a good idea to introduce them now. I still see many direct or indirect calls to exit() along the code paths that parse flows or actions. For example, nothing in lib/learn.c should exit, but I see many calls to ovs_fatal() or IF_PERR_EXIT() in learn_parse_load_immediate(). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
