On Sat, Mar 23, 2013 at 9:44 PM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Mar 22, 2013 at 04:31:11PM -0700, Gurucharan Shetty wrote: >> Currently, when flow attribute type is greater than OVS_KEY_ATTR_MAX, >> we can write into a random memory address causing corruption. Fix it. >> >> Bug #15702. >> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> > > Looks good. > > At the same time, it would be wise, I think to add > BUILD_ASSERT(OVS_KEY_ATTR_MAX < CHAR_BIT * sizeof present_attrs); > since we currently try to keep track of all the attributes in a > uint64_t. Okay. I sent an incremental.
> > Thanks for tracking this down. I know it was time consuming. I found > the symptoms really puzzling. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev