On Sat, Mar 23, 2013 at 03:42:58PM -0700, Ethan Jackson wrote: > As time goes on, and flow tables become more complicated, the > tradeoff between keeping up to date statistics, and the CPU > resources needed to maintain them, will become more important. > Commit 5c0243a (ofproto-dpif: xlate actions once with subfacets.) > delayed the reporting of some statistics in an effort to achieve > higher flow setup performance. Future commits will continue in the > same direction. > > This patch helps to alleviate the issue, by pushing statistics > rule_get_stats(), when users actually want them. Presumably, this > happens rarely, and thus will not have a negative impact on > ovs-vswitchd performance.
I'm willing to believe that. Anyway, it can't cause much extra work, since it only has an effect for facets that have stats that haven't previously been pushed. (I guess you verified that this can happen in cases where we don't already push the stats? I can believe that, but I don't know off-hand, and I did not verify it myself.) Looks good. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
