On Fri, Mar 15, 2013 at 03:07:33PM -0700, Jesse Gross wrote: > On Fri, Mar 15, 2013 at 7:27 AM, Simon Horman <ho...@verge.net.au> wrote: > > There were plans to use this in conjunction with inner/outer flows, > > however that plan has been changed in favour of using recirculation. > > This leaves us with the current usage. > > > > encal_dl_type is currently only used to allow decoding of packets used in > > the test suite. However, this is a bit of a fudge and the packets may be > > provided as hexadecimal instead. > > > > Also remove comments from parse_l2_5_onward() relating to MPLS which are > > not in keeping with the commenting throughout the rest of the function. > > > > Signed-off-by: Simon Horman <ho...@verge.net.au> > > Also applied. > > Can we also remove mpls_depth? It doesn't seem very safe to me > because it is extracted in userspace but the kernel flow could vary.
Yes, there are some problems there. I think that at the very least mpls_depth could be moved from the flow to the ctx. And then probably replaced with a copy of the stack itself as the depth seems to be insufficient to track all types of changes. An example I have in mind which isn't detected by simply tracking the stack depth is pop_mpls,set_mpls,push_mpls _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
