On Thu, Mar 14, 2013 at 01:54:01PM -0700, Gurucharan Shetty wrote:
> We use ovs-ctl from startup scripts to start, stop, restart,
> force-reload-kmod OVS daemons. ovs-ctl gives quite a descriptive
> o/p while running the above commands. But the o/p goes to stdout.
> Sometimes, this output is quite useful to debug issues.
>
> With this patch, we store the o/p of ovs-ctl when called from
> startup scripts in /var/log/openvswitch/ovs-ctl.log
>
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
Looks good.
It wouldn't hurt to put the filenames in "" quotes here:
> +ovs_ctl () {
> + echo "`date -u`:$@" >> ${logdir}/ovs-ctl.log
> + ${datadir}/scripts/ovs-ctl "$@" 2>&1 | tee -a ${logdir}/ovs-ctl.log
> +}
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
