Acked-by: Ethan Jackson <et...@nicira.com>
On Thu, Jan 24, 2013 at 2:44 PM, Ben Pfaff <b...@nicira.com> wrote:
> Found by Coverity.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> ovsdb/ovsdb-tool.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
> index 6b75f49..b50b39b 100644
> --- a/ovsdb/ovsdb-tool.c
> +++ b/ovsdb/ovsdb-tool.c
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 2009, 2010, 2011, 2012 Nicira, Inc.
> + * Copyright (c) 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
> *
> * Licensed under the Apache License, Version 2.0 (the "License");
> * you may not use this file except in compliance with the License.
> @@ -435,8 +435,8 @@ print_db_changes(struct shash *tables, struct shash
> *names,
> ? shash_find_data(&table_schema->columns,
> column)
> : NULL);
> if (column_schema) {
> - const struct ovsdb_error *error;
> const struct ovsdb_type *type;
> + struct ovsdb_error *error;
> struct ovsdb_datum datum;
>
> type = &column_schema->type;
> @@ -448,6 +448,8 @@ print_db_changes(struct shash *tables, struct shash
> *names,
> ds_init(&s);
> ovsdb_datum_to_string(&datum, type, &s);
> value_string = ds_steal_cstr(&s);
> + } else {
> + ovsdb_error_destroy(error);
> }
> }
> if (!value_string) {
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
