> This: > if (error > && (!dpif_netdev_class_is_dummy(dp->class) || error != EOPNOTSUPP)) { > might be more readable as: > if (error > && !(error == EOPNOTSUPP && dpif_netdev_class_is_dummy(dp->class))) { > but it's up to you.
I agree, this is more readable so I've folded it in. This patch isn't actually useful until the tunnel unit tests are in, so I've decided to hold off on merging it. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev