Hi,
Originally I've intended to avoid such kind of messages:
Jan 3 17:18:13 localhost ovs-vswitchd: 00095|bond|INFO|bond bond0:
shift 0kB of load (with hash 79) from eth3 to eth1 (now carrying
1153733kB and 0kB load, respectively)
But now I see the log shows tx_bytes / 1024, which could be zero. And
such small hashes were chosen because my original patch lacked
hysteresis. Forget this patch.
Regards,
Zoli
On 07/01/13 19:36, Ben Pfaff wrote:
On Sat, Jan 05, 2013 at 09:42:02PM +0000, Zoltan Kiss wrote:
During rebalancing there could be hash entries with 0 bytes traffic
on them. It is unnecessary to move them.
Signed-off-by: Zoltan Kiss <zoltan.k...@citrix.com>
Can this ever trigger? I don't see how these hash entries would end
up on the list iterated by choose_entry_to_migrate(), because
bond_rebalance() skips over entries that have tx_bytes == 0 and does
not add them to the bond_slave's list:
for (e = &bond->hash[0]; e <= &bond->hash[BOND_MASK]; e++) {
if (e->slave && e->tx_bytes) {
e->slave->tx_bytes += e->tx_bytes;
list_push_back(&e->slave->entries, &e->list_node);
}
}
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
