On Sat, Jan 05, 2013 at 09:42:16PM +0000, Zoltan Kiss wrote:
> The hash entry tag connects to facet(s), not slaves.
>
> Signed-off-by: Zoltan Kiss <zoltan.k...@citrix.com>
> ---
> lib/bond.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bond.c b/lib/bond.c
> index a95c9b0..2446d7e 100644
> --- a/lib/bond.c
> +++ b/lib/bond.c
> @@ -50,7 +50,7 @@ VLOG_DEFINE_THIS_MODULE(bond);
> struct bond_entry {
> struct bond_slave *slave; /* Assigned slave, NULL if unassigned. */
> uint64_t tx_bytes; /* Count of bytes recently transmitted. */
> - tag_type tag; /* Tag for entry<->slave association. */
> + tag_type tag; /* Tag for entry<->facet association. */
> struct list list_node; /* In bond_slave's 'entries' list. */
> };
I think that the comment is actually correct. The tag changes
whenever a bond_entry moves from one bond_slave to another. It goes
without saying that this is also tied to a facet, since that's only
actual use for tags.
Some other comments in bond.c are clearly wrong. I'll send out a fix.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
