On Jan 7, 2013, at 9:50 AM, Jesse Gross <je...@nicira.com> wrote: > On Mon, Jan 7, 2013 at 2:45 AM, Jarno Rajahalme <jarno.rajaha...@nsn.com> > wrote: >> >> Signed-off-by: Jarno Rajahalme <jarno.rajaha...@nsn.com> >> --- >> ODP ports are now 32-bit, so OVSP_LOCAL should be too. >> (Internally, kernel module still keeps port numbers 16-bit, though.) > > Justin, I see two direct uses of OVSP_LOCAL in the ofproto directory. > I didn't check them carefully but at first glance they doesn't seem > right after the single datapath changes: > in-band.c: && nl_attr_get_u32(a) == OVSP_LOCAL) { > ofproto-dpif.c: if (!error && ofport->odp_port == OVSP_LOCAL) {
Great catch. I'll prepare patches in a bit. Thanks! --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev