On Sun, Dec 30, 2012 at 11:14:57AM +1300, Joe Stringer wrote: > Previously I misunderstood the way that the checksum works. I now > understand that the constants are in host-byte order, and the result > of the computation provides a checksum in the mirrored byte order. > This means the calculation will be wrong on big-endian systems (in > this case, value is le32, we return be32). There are a couple of > further steps missed out for correct calculation in this patch. I'll > work on fixing these.
Thanks. > I'm not sure why my sparse didn't pick this up, I've been using "make > C=1", and the only sparse error I see (for a lot of files) is > "/usr/include/bits/wchar.h:37:8: error: garbage at end: '\0' - 1 > 0". > I'm using Debian Squeeze to build (sparse is version 0.4.1 or so). Any > thoughts? Hmm. That is the distribution that I use when I use sparse, so that part is OK. It might be the sparse version that is the problem. I'm using commit 970d7169d75068 (I have updated the sparse.1 man page including the __bitwise...) of sparse. I think that might be beyond any released version. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
