On Fri, Dec 28, 2012 at 08:23:47AM +0200, Jarno Rajahalme wrote: > > On Dec 27, 2012, at 7:23 , ext Simon Horman wrote: > > > > > +static ovs_be16 > > +actions_allow_l3_extraction(const struct ofpact *ofpacts, size_t > > ofpacts_len) > > +{ > > + const struct ofpact *a; > > + > > + OFPACT_FOR_EACH (a, ofpacts, ofpacts_len) { > > + if (a->type == OFPACT_EXIT) > > + break; > > + if (a->type == OFPACT_POP_MPLS) > > + return ofpact_get_POP_MPLS(a)->ethertype; > > + } > > + > > + return htons(0); > > +} > > + > > I haven't checked this, but it appears that in places where this is used, > flow->encap_dl_type could be used instead.
Thanks, yes I think that is the case other than in handle_flow_miss_l3_extraction() where actions_allow_l3_extraction is used to set flow->encap_dl_type. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev