On Thu, Dec 27, 2012 at 12:37:27PM -0500, Jesse Gross wrote: > On Wed, Dec 26, 2012 at 8:16 PM, Ethan Jackson <et...@nicira.com> wrote: > > Theoretically, it's possible for netdev_get_status() to be called > > on a netdev-vport which hasn't had it's configuration set yet. In > > this case, netdev-vport would dereference a null pointer. This > > problem was found by Jesse Gross <je...@nicira.com> in review. > > > > Signed-off-by: Ethan Jackson <et...@nicira.com> > > Shouldn't we just fetch the config? It's pretty easy and seems a lot > less likely to cause surprises in the future.
As long as we're talking about theoretical situations, it's possible that the vport doesn't exist in the kernel yet. We let vports be created and configured in userspace before they get added to a datapath. In between, they're just userspace configuration data. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
