On Tue, Nov 27, 2012 at 01:35:37PM -0800, Ansis Atteka wrote: > On Tue, Nov 27, 2012 at 11:28 AM, Ben Pfaff <[email protected]> wrote: > > On Tue, Nov 27, 2012 at 10:45:42AM -0800, Ansis Atteka wrote: > >> The flow_format() function was incorrectly passing skb_priority > >> to the match_format() function. match_format() function instead > >> expects rule priority. > >> > >> Signed-off-by: Ansis Atteka <[email protected]> > > > > Good catch, thank you. > > > > Will you please cite the commit that added the bad match_format() call > > in the change log, so that it is easy to see what versions are > > affected? > > Sure, skb_priority has been used like this since the very beginning - > Nov 1 2011 (abff858b5ad310a529d5a5ac2a230ee4ac9736db datapath: Convert > kernel priority actions into match/set.). Though, that particular line > of code has been re-factored multiple times since then.
I didn't realize it went back that far. > Should I try to backport this all the way back to branch-1.4? No, it's not important enough, don't bother. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
