On Wed, Nov 21, 2012 at 1:51 PM, Ben Pfaff <[email protected]> wrote: > On Wed, Nov 21, 2012 at 01:49:37PM -0800, Pravin Shelar wrote: > > On Wed, Nov 21, 2012 at 1:31 PM, Ben Pfaff <[email protected]> wrote: > > > > > On Wed, Nov 21, 2012 at 12:30:13PM -0800, Pravin Shelar wrote: > > > > On Wed, Nov 21, 2012 at 12:10 PM, Ben Pfaff <[email protected]> wrote: > > > > > > > > > The only thing I noticed this time is that the test shows that > these > > > new > > > > > fields can't be sent in a flow_mod. I guess that > > > > > ofputil_usable_protocols() should signal this by returning 0 > (meaning > > > > > that no protocols can handle the flow) if any of the new fields > are not > > > > > entirely wildcarded. > > > > > > > > > > ok. > > > > ofputil_usable_protocols() returns ofputil_protocol. zero is not > defined > > > > value in this enum. > > > > so we can add new protocol that can be used show incompatibility of a > > > given > > > > flow? > > > > > > It's a bit-mask. 0 just means that none of the bits are set. > > > Does your compiler complain, or does it just bother you? > > > > > > > compiler is ok with it, I just thought making it explicit. But I setting > it > > to zero is fine with me. > > You can use OFPUTIL_P_NONE if you like. Its value is 0. >
Its better, will do.
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
