On Fri, Nov 16, 2012 at 07:52:46PM +0900, Simon Horman wrote: > On Thu, Nov 15, 2012 at 10:44:19PM -0800, Ben Pfaff wrote: > > See http://openvswitch.org/pipermail/dev/2012-November/022990.html > > for background. > > > > Ben Pfaff (5): > > ovs-ofctl: Style fix. > > ofp-util: Rename OFPUTIL_P_* constants and update comments for > > clarity. > > ofp-util: Allow use of OpenFlow 12 flow format > > ofp-util: Make ofputil_encode_set_protocol() able to return failure. > > nicira-ext: Remove NXFF_OPENFLOW12. > > > > include/openflow/nicira-ext.h | 3 +- > > lib/learning-switch.c | 20 +++-- > > lib/ofp-msgs.h | 2 +- > > lib/ofp-util.c | 191 > > +++++++++++++++++++++-------------------- > > lib/ofp-util.h | 52 +++++++---- > > ofproto/connmgr.c | 4 +- > > tests/learn.at | 2 +- > > tests/ovs-ofctl.at | 12 +-- > > utilities/ovs-ofctl.c | 5 +- > > 9 files changed, 159 insertions(+), 132 deletions(-) > > This all seems reasonable to me. > > Reviewed-by: Simon Horman <ho...@verge.net.au>
Thanks for the reviews, I pushed these to master. I'll continue to work along your series as I find time. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev