On Tue, Nov 13, 2012 at 05:33:09PM -0800, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar <pshe...@nicira.com>
These patches seem reasonable to me (I hope Jesse looks at them too) but I have one suggestion for the format. This: set(ipv4_tunnel(tun_id=0xabcdef1234567890,src=1.1.1.1,dst=2.2.2.2,tos=0x0,ttl=64,flags=df,csum,key,0x20)) looks a little funny to me because csum, key, and 0x20 are all part of the flags but setting them off by commas this way makes them look like separate fields. So, how about this: set(ipv4_tunnel(tun_id=0xabcdef1234567890,src=1.1.1.1,dst=2.2.2.2,tos=0x0,ttl=64,flags(df,csum,key,0x20))) If there are no flags then I'd be happy with flags() or flags(0x0). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
