On Tue, Nov 13, 2012 at 05:32:56PM -0800, Pravin B Shelar wrote:
> These functions are used in next patch.
> 
> Signed-off-by: Pravin B Shelar <pshe...@nicira.com>

I don't really understand how one should interpret SLOW_MAX.  Also, it's
not really a member of the enumeration, so probably a #define would be
better.

It looks like something like:
        #define SLOW_ALL ((1 << 6) - 1)
has a more obvious interpretation and would avoid the extra switch cases
for the enum.

I may have other comments later; I didn't read the whole patch yet.
(But if Jesse approves it, that's fine.)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to