The length of the hello version bitmap is measured in bytes
so the return value of sizeof is sufficient. Dividing
this by CHAR_BIT (=8) seems to be an artifact of reworking
a previous version of this code.
Signed-off-by: Simon Horman <ho...@verge.net.au>
---
v4
* First post
---
lib/ofp-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index ae54477..5703f8c 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1181,7 +1181,7 @@ ofputil_encode_hello(uint32_t allowed_versions)
struct ofp_hello_elem_header *oheh;
uint16_t map_len;
- map_len = sizeof(uint32_t) / CHAR_BIT;
+ map_len = sizeof allowed_versions;
oheh = ofpbuf_put_zeros(msg, ROUND_UP(map_len + sizeof *oheh, 8));
oheh->type = htons(OFPHET_VERSIONBITMAP);
oheh->length = htons(map_len + sizeof *oheh);
--
1.7.10.4
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
