On Tue, Nov 6, 2012 at 10:21 AM, Ansis Atteka <aatt...@nicira.com> wrote:
> On Tue, Nov 6, 2012 at 8:16 PM, Jesse Gross <je...@nicira.com> wrote: > > On Tue, Nov 6, 2012 at 7:25 AM, Ansis Atteka <aatt...@nicira.com> wrote: > >> > >> This patch prepares ipv6_find_hdr() function so that it could be > >> able to skip routing headers, where segements_left is 0. This is > >> required for us to handle multiple routing header case correctly. > >> > >> Signed-off-by: Ansis Atteka <aatt...@nicira.com> > > > > > > This looks like a good approach to me. > > > > Acked-by: Jesse Gross <je...@nicira.com> > > Thanks, I think I had a small typo here In exthdrs_core.c. It should > be rpl_ipv6_find_hdr() and not ipv6_find_hdr(). > > The function from iptables most likely will not conflict here, but I > think that I should change it for the sake of consistency? > It's not strictly necessary since the #define will deal with it but renaming to make it clear it is different isn't a bad idea.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
