On Thu, Oct 25, 2012 at 02:42:23PM +0900, Isaku Yamahata wrote:
> This implementes push_vlan with 802.1Q.
> NOTE: 802.1AD (QinQ) is not supported. It requires another effort.
> 
> Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp>

The check that this patch does in ofpact_check__() should be moved
into ofpact_from_openflow11(), because it does not require knowledge
of the flow.

Given that, I'm not sure that there's a benefit to carrying the
ethertype in the ofpact structure at all.

We should document this action in ovs-ofctl.8.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to