Thanks. It looks good to me (except that the indentation looks off, but that could be an effect of my mail client). But Jesse needs to review it.
Thanks, Ben. On Tue, Oct 23, 2012 at 01:47:12PM -0700, Mehak Mahajan wrote: > Hey Ben, > > What you are saying makes perfect sense. > > I have sent out a new patch which removes the opcode check altogether. > http://openvswitch.org/pipermail/dev/2012-October/022194.html > > thanx! > mehak > > On Fri, Oct 19, 2012 at 2:44 PM, Ben Pfaff <b...@nicira.com> wrote: > > > On Fri, Oct 19, 2012 at 01:39:59PM -0700, Mehak Mahajan wrote: > > > With this commit, the datapath will process the ARP header for > > > RARP packets, both request and reply. > > > > > > Signed-off-by: Mehak Mahajan <mmaha...@nicira.com> > > > > It looks very much to me like all defined ARP opcodes (at least the > > ones listed here: > > http://www.networksorcery.com/enp/protocol/arp.htm#Opcode) use the > > same packet format. Would it be better to simply remove the protocol > > check, rather than to whitelist more values? > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
