We've typically used WARN_ONCE for this sort of thing. Not sure it
matters that much though.
Acked-by: Ethan Jackson <et...@nicira.com>
On Thu, Sep 20, 2012 at 8:45 AM, Ben Pfaff <b...@nicira.com> wrote:
> This is a necessary step toward supporting full 32-bit OF1.1+ port numbers
> in a later version of OVS.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> NEWS | 13 +++++++------
> lib/ofp-util.c | 6 +++---
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 38e5129..29fd9f3 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -28,12 +28,13 @@ post-v1.8.0
> program was not included in distribution packaging.)
> - ovsdb-server now enforces the immutability of immutable columns. This
> was not enforced in earlier versions due to an oversight.
> - - Stable bond mode is deprecated and will be removed no earlier than
> - February 2013. Please email dev@openvswitch.org with concerns.
> - - The autopath action is deprecated and will be removed no earlier than
> - February 2013. Please email dev@openvswitch.org with concerns.
> - - The null interface type is deprecated and will be removed no earlier
> - than February 2013. Please email dev@openvswitch.org with concerns.
> + - The following features are now deprecated. They will be removed no
> + earlier than February 2013. Please email dev@openvswitch.org with
> + concerns.
> + - Stable bond mode.
> + - The autopath action.
> + - Interface type "null".
> + - Numeric values for reserved ports (see "ovs-ofctl" note above).
>
>
> v1.8.0 - xx xxx xxxx
> diff --git a/lib/ofp-util.c b/lib/ofp-util.c
> index fc98894..c214882 100644
> --- a/lib/ofp-util.c
> +++ b/lib/ofp-util.c
> @@ -3569,9 +3569,9 @@ ofputil_port_from_string(const char *s)
>
> ds_init(&s);
> ofputil_format_port(port32, &s);
> - VLOG_WARN("port %u is better referred to as %s, for
> compatibility "
> - "with future versions of OpenFlow",
> - port32, ds_cstr(&s));
> + VLOG_WARN("referring to port %s as %u is deprecated for "
> + "compatibility with future versions of OpenFlow",
> + ds_cstr(&s), port32);
> ds_destroy(&s);
>
> return port32;
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
