On Thu, Sep 20, 2012 at 05:04:51PM -0700, Ethan Jackson wrote:
> ovs-vswitchd should only write to write-only columns.  Furthermore,
> writing to a column which is not write-only can cause serious
> performance degradations.  This patch causes ovs-vswitchd to log

I'd add ", because a write to a read/write column causes ovs-vswitchd
to think that its configuration has changed and spend a significant
amount of time attempting to reconfiguring itself."

> and reject writes to read-write columns.
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>
> ---
> 
> Here's an updated version.

The code looks good.

I think we could use some more background in the comment on
ovsdb_idl_verify_write_only() though.  How about using the first two
sentences of your commit message?

(I don't think that we need another go-around on this patch, just do
what you think makes sense and commit it.  Thank you!)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to