On Tue, Sep 11, 2012 at 01:30:04PM +0900, Simon Horman wrote: > From: Isaku Yamahata <yamah...@valinux.co.jp> > > Use a uninion mf_subvalue instead of a uint64_t for > the value member of struct ofpact_reg_load. > > set_field action needs to hold values wider than 64 bits. > This is preparation for set_field action. > > Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp> > Signed-off-by: Simon Horman <ho...@verge.net.au> > > --- > > v4 [Simon Horman] > * Use union mf_subfield instead of union mf_value > as suggested by Ben Pfaff
Thank you. This is much closer to what I had in mind. One remaining nit is that nxm_format_reg_load() is going to drop significant bits if it ever formats a subvalue wider than 64 bits. I suggest moving format_subvalue() from lib/learn.c into meta-flow.[ch] (renaming appropriately) and then using that in nxm_format_reg_load(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
