On Wed, Aug 29, 2012 at 10:41:32AM -0700, Ben Pfaff wrote: > On Tue, Aug 21, 2012 at 01:55:40PM +0900, Simon Horman wrote: > > Open Flow 1.1 and 1.2 make use of 32 bit ports, > > however Open vSwtich maps them to 16 bits. Make > > ovs-ofputl aware of this. > > > > Also, only accept ports that fit into 16 bits > > for Open Flow 1.0. > > > > Signed-off-by: Simon Horman <[email protected]> > > In str_to_port_no(), only the "if" and not the "else" case can fall > through to the ovs_fatal() call at the end of the function, so the > ovs_fatal() would be better put into the "if" case. Also, the wording > of the message in the ovs_fatal() case is odd; at the very least there's > a missing space. > > Otherwise I'm happy with this, thank you. I would have applied it with > those two nits fixed up, but some patch that I didn't apply earlier > caused patch rejects.
Thanks, I'll clean up the if-else problem and rebase. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
