On Thu, Aug 16, 2012 at 11:52:43AM -0400, Ed Maste wrote:
> > From 3150ae27f6022aa6ffdfdf57f85808a5429f7a07 Mon Sep 17 00:00:00 2001
> > From: Ben Pfaff <b...@nicira.com>
> > Date: Thu, 16 Aug 2012 08:36:42 -0700
> > Subject: [PATCH] dpif-netdev: Fix memory leak.
> >
> > upcall->packet is allocated with malloc(), via ofpbuf_new(), but nothing
> > ever frees it.
> >
> > Found by valgrind.
> >
> > CC: Ed Maste <ema...@freebsd.org>
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > ---
> > lib/dpif-netdev.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> > index 7fa2720..63b59a3 100644
> > --- a/lib/dpif-netdev.c
> > +++ b/lib/dpif-netdev.c
> > @@ -966,6 +966,8 @@ dpif_netdev_recv(struct dpif *dpif, struct dpif_upcall
> > *upcall,
> >
> > ofpbuf_uninit(buf);
> > *buf = *upcall->packet;
> > + free(upcall->packet);
> > + upcall->packet = buf;
> >
> > return 0;
> > } else {
> > --
> > 1.7.2.5
>
> This version looks good and passed a quick sanity test on my threaded branch.
Thanks. I pushed this to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
