On Wed, Aug 08, 2012 at 08:57:56PM -0700, Ben Pfaff wrote:
> On Thu, Aug 09, 2012 at 12:21:36PM +0900, Simon Horman wrote:
> > On Tue, Aug 07, 2012 at 11:50:19AM -0700, Ben Pfaff wrote:
> > > The learning-switch implementation needs to know the OpenFlow version in
> > > use to send the initial handshake messages (e.g. the feature request), but
> > > the version is not always available at the time that the code currently
> > > sends the handshake.  This can cause an assertion failure later when
> > > ofputil_encode_flow_mod() checks the protocol, which will be 0 if the
> > > version wasn't known.
> > > 
> > > This commit fixes the problem by introducing a state machine that sends 
> > > the
> > > handshake messages only after version negotiation has finished.
> > 
> > I have done a limited amount of testing of this,
> > using Ryu and ovs-controller, and the results look good.
> 
> I don't see how Ryu would be relevant, since it is also a controller,
> but I'll take your word for it that it works for you too.

True, scratch the Ryu portion of the comment above.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to