On Tue, Jul 24, 2012 at 09:13:11PM -0700, Ben Pfaff wrote: > On Mon, Jul 23, 2012 at 05:08:40PM +0900, Isaku Yamahata wrote: > > They will be used by other files like ofp-parser.c. > > > > Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp> > > I'm not sure why this patch is needed. Aren't these only useful for > working with the raw OpenFlow instruction encoding?
They are also useful for text parsing/formating. NAME argument for the macro DEFINE_INST is defined for that purpose, isn't it? NAME isn't used in ofp-actions.c in the git HEAD. > The goal of the > "ofpact" representation is to avoid the need for code outside > ofp-actions.c to work with raw OpenFlow instruction and action > encodings, so this would seem to defeat part of that purpose. Yes, so abstracted instruction codes, OVSINST_xxx, need to be exported like ofp-util.def. -- yamahata _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
