Looks good to me.

Ethan

On Tue, Jul 24, 2012 at 3:43 PM, Ben Pfaff <b...@nicira.com> wrote:
> This fixes the following warning from "sparse":
>
> meta-flow.c:830:31: warning: incorrect type in return expression (different
> base types)
> meta-flow.c:830:31:    expected bool
> meta-flow.c:830:31:    got restricted __be16
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
>  lib/meta-flow.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index c50cfc5..3713ca4 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -827,7 +827,7 @@ mf_are_prereqs_ok(const struct mf_field *mf, const struct 
> flow *flow)
>      case MFP_IPV6:
>          return flow->dl_type == htons(ETH_TYPE_IPV6);
>      case MFP_VLAN_VID:
> -        return flow->vlan_tci & htons(VLAN_CFI);
> +        return (flow->vlan_tci & htons(VLAN_CFI)) != 0;
>      case MFP_IP_ANY:
>          return is_ip_any(flow);
>
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to