On Fri, Jul 20, 2012 at 07:53:02PM +0000, Kyle Mestery (kmestery) wrote:
> On Jul 20, 2012, at 1:52 PM, Ben Pfaff wrote:
> > On Wed, May 23, 2012 at 09:34:07AM -0700, Ben Pfaff wrote:
> >> The function ofputil_decode_msg_type_partial() can figure out the type of
> >> a truncated OpenFlow message, if the message is long enough that its type
> >> can be determined, so we should print this information.   This is
> >> especially valuable for printing OFPT_ERROR messages, in which the inner
> >> OpenFlow message is often truncated to 64 bytes.
> >> 
> >> Signed-off-by: Ben Pfaff <b...@nicira.com>
> > 
> > I think this patch has fallen through the cracks.  I haven't noticed a
> > review since I posted it on May 23.
> 
> Just went back and eyeballed this one, looks good to me, and will be
> useful for debugging as well.

Thank you for the review.  Applied to master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to