Thanks, applied to master.
On Fri, Jul 20, 2012 at 11:09:00AM -0700, Pravin Shelar wrote: > Looks good. > > Thanks. > > On Fri, Jul 20, 2012 at 10:25 AM, Ben Pfaff <b...@nicira.com> wrote: > > Otherwise the kernel will reject it later and the result is no tunnel, > > whereas a tunnel with an unexpected TOS seems like a better result. > > > > Bug #12566. > > Reported-by: Luca Giraudo <lgira...@nicira.com> > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > --- > > lib/netdev-vport.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c > > index 836069f..db5c3db 100644 > > --- a/lib/netdev-vport.c > > +++ b/lib/netdev-vport.c > > @@ -614,8 +614,10 @@ parse_tunnel_config(const char *name, const char *type, > > char *endptr; > > int tos; > > tos = strtol(node->value, &endptr, 0); > > - if (*endptr == '\0') { > > + if (*endptr == '\0' && tos == (tos & IP_DSCP_MASK)) { > > nl_msg_put_u8(options, OVS_TUNNEL_ATTR_TOS, tos); > > + } else { > > + VLOG_WARN("%s: invalid TOS %s", name, node->value); > > } > > } > > } else if (!strcmp(node->key, "ttl")) { > > -- > > 1.7.2.5 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev