FWIW, it does look correct to me. Thanks. --Justin
On Jul 19, 2012, at 9:27 AM, Ben Pfaff wrote: > Commit 32455024 (OXM: Allow masking of IPv6 Flow Label) made the flow label > maskable but did not update mf_get_mask() accordingly. > > CC: Simon Horman <ho...@verge.net.au> > Signed-off-by: Ben Pfaff <b...@nicira.com> > --- > I noticed this while looking through patch 3/3. I'm going to push > this fix in a minute. > > lib/meta-flow.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index 8bc3d1a..a5505c9 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c > @@ -647,7 +647,6 @@ mf_get_mask(const struct mf_field *mf, const struct > flow_wildcards *wc, > case MFF_IP_DSCP: > case MFF_IP_ECN: > case MFF_IP_TTL: > - case MFF_IPV6_LABEL: > case MFF_ARP_OP: > case MFF_ARP_SHA: > case MFF_ARP_THA: > @@ -699,6 +698,9 @@ mf_get_mask(const struct mf_field *mf, const struct > flow_wildcards *wc, > case MFF_IPV6_DST: > mask->ipv6 = wc->ipv6_dst_mask; > break; > + case MFF_IPV6_LABEL: > + mask->be32 = wc->ipv6_label_mask; > + break; > > case MFF_ND_TARGET: > mask->ipv6 = wc->nd_target_mask; > -- > 1.7.2.5 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
