On Tue, Jul 10, 2012 at 03:10:07PM -0700, Jesse Gross wrote: > On Tue, Jul 10, 2012 at 2:28 PM, Ben Pfaff <b...@nicira.com> wrote: > > At the point where it was used, skb_shinfo(skb)->gso_type referred to a > > post-GSO sk_buff. Thus, it would always be 0. We want to know the pre-GSO > > gso_type, so we need to obtain it before segmenting. > > > > Before this change, the kernel would pass inconsistent data to userspace: > > packets for UDP fragments with nonzero offset would be passed along with > > flow keys that indicate a zero offset (that is, the flow key for "later" > > fragments claimed to be "first" fragments). This inconsistency tended > > to confuse Open vSwitch userspace, causing it to log messages about > > "failed to flow_del" the flows with "later" fragments. > > > > Bug #12394. > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > Acked-by: Jesse Gross <je...@nicira.com>
Thanks, pushed to master and branch-1.[4567]. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
