Commit 2a586a5 (ipsec gre: Do not reread ovs monitor ipsec pidfile in
netdev vport so much) attempts to cache the pid of ovs-monitor-ipsec so
that it's not re-checked so often. Unfortunately, it also cached error
returns, so errors never recover. This commit continues to check for
the process's existence after an error.
Issue #12399
Reported-by: Paul Ingram <p...@nicira.com>
Signed-off-by: Justin Pettit <jpet...@nicira.com>
---
lib/netdev-vport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index d2c2672..836069f 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -682,7 +682,7 @@ parse_tunnel_config(const char *name, const char *type,
if (is_ipsec) {
static pid_t pid = 0;
- if (pid == 0) {
+ if (pid <= 0) {
char *file_name = xasprintf("%s/%s", ovs_rundir(),
"ovs-monitor-ipsec.pid");
pid = read_pidfile(file_name);
--
1.7.5.4
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
