On Fri, Jul 06, 2012 at 02:59:05PM +0200, Giuseppe Lettieri wrote: > the attached patch implements new netdev classes for "system" and "tap" > devices in FreeBSD, by using the libpcap library. With this patch (and > some firewall rules) the user-level datapath of Open vSwitch can be made > to work on FreeBSD. > > Please note that most of the real work has been done by Gaetano Catalli, > who does not work here anymore. My only contribution has been the > porting of his work on top of the master branch. I have not yet > contacted him for a signoff, so I am not proposing the patch for > immediate merge. Instead, together with Ed Maste who is collaborating on > this porting, we thought that we could benefit from developers' comments. > > Best regards, > Giuseppe Lettieri
At first glance it looks very reasonable to me. I even agree with some of the comments that suggest changes to the Open vSwitch netdev internals. I spotted at least one printf() that should be a VLOG_*() or removed. I think there are a few opportunities for common code between the Linux and FreeBSD implementations, but that can come later. A comment mentions a need to edit coverage-counters.c but that should not be necessary. Just add COVERAGE_DEFINE(...name...); at the top level. I look forward to a signed-off version. I didn't try building it but I probably will (in a FreeBSD VM) before I apply it. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
