On Wed, Jun 27, 2012 at 01:26:55PM +0900, Isaku Yamahata wrote: > This patch is preliminary to support set_field action. > Although it is only compile tested, I'd like to hear if this is the right > direction before going further.
Thanks. I'm not sure. I considered going a similar direction myself, but I think I decided that retaining discrete "set field" actions for OF1.0 and OF1.1 make it easier to accurately reproduce the actions that the controller sent (see my comments on the final patch for details). set-field.c is also larger than I would have guessed. > Once this is done, I'd like to add instruction support next. > For that, introduce OFPACT_IT_xxx and teach struct action_xlate_ctx and > do_xlate_actions() instructions. Is this the dirction to go? Or other way? Did you see the start of instruction support in my own "of1.1 v2" series? So far, it only supports the "Apply-Actions" instruction, but I think that adding support for other instructions should be fairly straightforward. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
