On Mon, Jun 25, 2012 at 02:33:14PM -0700, Gurucharan Shetty wrote:
> There can be possibilities where there are hundreds of OVS
> internal devices. In such a situation, running ovs-bugtool
> can take a very long time to complete as multiple ethtool
> commands are run on each interface in /sys/class/net. Once
> the ovs-bugtool completes, most of the ethtool command outputs
> would be incomplete with "timeouts" as we only give 30 seconds
> for CAP_NETWORK_STATUS.
>
> With the following patch, we only run ethtools on those interfaces
> that have an associated "device". All physical interfaces have
> this entry in /sys/class/net/${interface_name}/. Virtual interfaces
> can have this entry too, if it has an underlying virtual device.
>
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
This looks good but I think we could eliminate a little bit of code
duplication by dropping the final TC command from the "if islink and
int" block and then changing the "elif" to a plain "if".
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
