On Fri, Jun 15, 2012 at 09:03:28AM +0900, Simon Horman wrote:
> On Tue, Jun 12, 2012 at 12:32:20AM -0700, Ben Pfaff wrote:
> > This builds and doesn't break any existing unit tests, but nothing
> > calls it yet (and it doesn't have any unit tests of its own) so it
> > can hardly be called useful.
> > +exit:
> > if (error) {
> > ofpbuf_clear(ofpacts);
> > }
>
> The next and last line of ofpacts_pull_openflow11_instructions() ends up
> being:
>
> return 0;
>
> I wonder if it should be:
>
> return error;
Yes, thanks, fixed up.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
