On Thu, Jun 07, 2012 at 10:48:25PM -0700, Mehak Mahajan wrote: > With this change there is no need to restart the DB or OVS on configuring a > different value for the manager or controller connection respectively. On > detecting a change in the dscp value on the socket, the previous socket is > closed and a new socket is created and connection is established with the new > configured dscp value. > > Signed-off-by: Mehak Mahajan <mmaha...@nicira.com>
I'd be inclined to change jsonrpc_session_set_dscp() differently: instead of telling the caller whether the options changed, simply reconnect automatically in that case. Instead of exposing jsonrpc_session_connect(), I think it would be better to use the existing function jsonrpc_session_force_reconnect(). I'd suggest changing rconn_set_dscp() the same way (that is, to drop the connection if the dscp really changes), and then modifying ofconn_reconfigure() to always call rconn_set_dscp(), the same way it always calls the other functions to configure the rconn. Then, I don't think there is a need to change connmgr_set_controllers() or to add the two new functions in connmgr.c. I don't think there is any need to change vswitchd/vswitch.ovsschema at all. Also for lib/socket-util.c. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
