On Thu, Jun 14, 2012 at 2:23 AM, Jesse Gross <[email protected]> wrote: > On Wed, Jun 6, 2012 at 4:55 AM, Pravin B Shelar <[email protected]> wrote: >> From kernel 3.4 netdevice structure has delayed_work in >> net_device->pm_qos_req. OVS has its own workq implementation >> which redefines delayed_work. Therefore we can no longer >> redefine delay_work in ovs. >> >> Following patch defines compat workq as ovs specific workq library. >> >> Signed-off-by: Pravin B Shelar <[email protected]> > > Hmm, OVS never does anything with net_device->pm_qos_req (and seems > unlikely to). What if we have our workqueue library include > linux/netdevice.h first so that we're guaranteed to get the size for > struct net_device right and then use our normal trick of macros to > replace the names in OVS?
It is not just accessing net_device->pm_qos_req, all net_device members after that are affected as it changes all offsets due to difference in size of struct workq. I am not sure about include order as netdevice.h might have some header which includes workqueue.h _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
