On May 14, 2012, at 1:59 PM, Ben Pfaff wrote:

> +# PYTHONDONTWRITEBYTECODE=yes keeps Python from creating .pyc and .pyo
> +# files.  Creating .py[co] works OK for any given version of Open
> +# vSwitch, but it causes trouble if you switch from a version with
> +# foo/__init__.py into an (older) version with plain foo.py, since
> +# foo/__init__.pyc will cause Python to ignore foo.py.
> +run_python = \
> +     PYTHONDONTWRITEBYTECODE=yes \
> +     PYTHONPATH=$(top_srcdir)/python:$$PYTHON_PATH \
> +     $(PYTHON)

I know that you just copied this from the earlier code, but is PYTHON_PATH 
correct?  I don't see any other place that uses it and Python seems to only 
respect PYTHONPATH.

It looks like PYTHONDONTWRITEBYTECODE was added in Python 2.6.  Do you think 
it's worth mentioning somewhere in case people get odd results?  Otherwise, 
looks good to me.

--Justin


_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to