On Wed, May 16, 2012 at 4:13 PM, Pravin B Shelar <pshe...@nicira.com> wrote: > diff --git a/datapath/tunnel.c b/datapath/tunnel.c > index c2133bb..d3e2d20 100644 > --- a/datapath/tunnel.c > +++ b/datapath/tunnel.c > @@ -1219,7 +1222,6 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff > *skb) > else > tos = mutable->tos; > > - tos = INET_ECN_encapsulate(tos, inner_tos); >
There's an extra blank line here now. > /* Route lookup */ > rt = find_route(vport, mutable, tos, &cache); > @@ -1270,6 +1272,7 @@ int ovs_tnl_send(struct vport *vport, struct sk_buff > *skb) > #endif > } > > + tos = INET_ECN_encapsulate(tos, inner_tos); I would keep this just below the route lookup so that all the ToS calculations are relatively close together. Otherwise this looks fine though. Acked-by: Jesse Gross <je...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
